Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tarantool version verification for feature toggling #40

Open
akudiyar opened this issue Nov 13, 2020 · 1 comment
Open

Implement Tarantool version verification for feature toggling #40

akudiyar opened this issue Nov 13, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@akudiyar
Copy link
Collaborator

Problem statement

Currently, the Tarantool version is not checked which may lead to the user receiving server errors or missing features like updating by JSON paths since Tarantool 2.3.

Proposed solution

Implement checking the Tarantool version and a service for fencing the parts of code depending on the current Tarantool version:

  • parse the Tarantool header into parts (currently the version is not parsed)
  • use the version holder in a singleton service
  • add new exception type
  • make version holder stick with connection, implement cross-checking of version in connections (either forbid connecting of one driver instance to the servers with different versions or maintain the minimal version (?)
@akudiyar akudiyar added enhancement New feature or request 2sp labels Nov 13, 2020
@akudiyar akudiyar added this to the Q4 2020 milestone Nov 13, 2020
@akudiyar akudiyar modified the milestones: Q4 2020, Q1 2021 Nov 30, 2020
@vrogach2020 vrogach2020 removed this from the Q1 2021 milestone Sep 14, 2021
@sharonovd sharonovd added this to the wishlist milestone Sep 21, 2021
@TarantoolBot TarantoolBot removed the 2sp label Jun 14, 2023
@dkasimovskiy
Copy link
Contributor

Ween need to look at IPROTO ID feature in Tarantool 2.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants