Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent upsert return values #357

Open
DifferentialOrange opened this issue Mar 29, 2023 · 0 comments
Open

Inconsistent upsert return values #357

DifferentialOrange opened this issue Mar 29, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@DifferentialOrange
Copy link
Member

Core Tarantool space:upsert API is a specific one: it always return nil in case of success. Following this, crud.upsert and crud.upsert_many responses do not have any tuples data. But they do it different.

crud.upsert success response is { rows = {}, metadata = ... }, while crud.upsert_many is { metadata = ... } (res.rows == nil). This doesn't sound good. And while it's should be rather easy to fix, we should make sure to make a smooth transition for a user through behavior deprecation first.

The other question that may follow this one is "Why do we return metadata if it's never useful?", but it is likely to be resolved by #267.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants