Remove server:clean() method

The method was removed because there was an ambiguous understanding of
the differences between the `stop()`, `drop()` and `clean()` methods.

Part of #253

CHANGELOG.md

@@ -14,7 +14,6 @@
   * Add waiting until the process of the stopped server is terminated.
   * Add new functions:
     - `Server.build_listen_uri()`
-    - `Server:clean()`
     - `Server:drop()`
     - `Server:wait_until_ready()`
     - `Server:get_instance_id()`

luatest/replica_set.lua

@@ -169,19 +169,10 @@ function ReplicaSet:stop()
     end
 end
 
---- Clean working directories of all servers in the replica set.
--- Should be invoked only for a stopped replica set.
-function ReplicaSet:clean()
-    for _, server in ipairs(self.servers) do
-        server:clean()
-    end
-end
-
 --- Stop all servers in the replica set and clean their working directories.
 function ReplicaSet:drop()
     for _, server in ipairs(self.servers) do
-        server:stop()
-        server:clean()
+        server:drop()
     end
 end
 

luatest/server.lua

@@ -358,18 +358,14 @@ function Server:stop()
     end
 end
 
---- Clean the server's working directory.
--- Should be invoked only for a stopped server.
-function Server:clean()
-    fio.rmtree(self.workdir)
-    self.instance_id = nil
-    self.instance_uuid = nil
-end
-
 --- Stop the server and clean its working directory.
 function Server:drop()
     self:stop()
-    self:clean()
+
+    fio.rmtree(self.workdir)
+
+    self.instance_id = nil
+    self.instance_uuid = nil
 end
 
 --- Wait until the server is ready after the start.

test/server_test.lua

@@ -322,13 +322,13 @@ g.test_wait_when_server_is_not_running_by_bad_option = function()
     t.assert_equals(status, false)
     t.assert_str_contains(msg, expected_msg)
     t.assert_equals(s1.process:is_alive(), false)
-    s1:clean()
+    s1:drop()
 
     status, msg = pcall(Server.start, s2)
     t.assert_equals(status, false)
     t.assert_str_contains(msg, expected_msg)
     t.assert_equals(s2.process:is_alive(), false)
-    s2:clean()
+    s2:drop()
 end
 
 g.test_drop_server_if_process_is_dead = function()