Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package and ship github-to-sops with pip #324

Closed
humphd opened this issue Jan 10, 2024 · 11 comments
Closed

Package and ship github-to-sops with pip #324

humphd opened this issue Jan 10, 2024 · 11 comments
Assignees
Milestone

Comments

@humphd
Copy link
Collaborator

humphd commented Jan 10, 2024

We're using sops and GitHub to secure secrets in the repo, and @tarasglek has created a neat Python tool to make it easier to do: https://github.com/tarasglek/github-to-sops. Let's get this packaged so it can be installed with pip

@tarasglek
Copy link
Owner

@humphd
Copy link
Collaborator Author

humphd commented Jan 17, 2024

https://github.com/prefix-dev/rattler-build/blob/main/examples/rich/recipe.yaml for an example of doing this with rattler-build for conda.

@humphd
Copy link
Collaborator Author

humphd commented Jan 18, 2024

@rjwignar
Copy link
Collaborator

I'd like to look into Willison's method

@humphd
Copy link
Collaborator Author

humphd commented Jan 18, 2024

@rjwignar awesome, thank you. I would suggest you continue work in the gitub-to-sops repo vs. here, but I'll leave this open as a tracking issue.

Don't pay attention to what I've done for rattler; do what Simon says to do. The rattler build can leverage whatever you do with pip.

@humphd
Copy link
Collaborator Author

humphd commented Jan 24, 2024

We should figure out which pieces of this we can get done by 1.1 (next Friday), even if we can't get it all in by then.

@rjwignar
Copy link
Collaborator

rjwignar commented Jan 29, 2024

I recently made a PR that modifies github-to-sops's directory structure to match that produced by Willison's cookiecutter template.
Among other things, the cookiecutter template also adds a workflow that publishes package releases to PyPI.

Publishing to PyPI first requires filling a Pending Publisher form to use PyPI's Trusted Publishers mechanism. Here's an example form Willison filled out for one of his libraries:
image

I haven't tried it yet, but I think I'd be able to fill out (using the github-to-sops repo info) and submit the form even though I'm not the repo owner.

@humphd
Copy link
Collaborator Author

humphd commented Jan 29, 2024

@WangGithub0 do you want to review tarasglek/github-to-sops#3 as well, since you did something similar for the TypeScript module?

@WangGithub0
Copy link
Collaborator

tarasglek/github-to-sops#3

sure, I'll do it

@rjwignar rjwignar modified the milestones: Release 1.1, Release 1.2 Feb 2, 2024
@humphd
Copy link
Collaborator Author

humphd commented Feb 9, 2024

@rjwignar can we close this now?

@rjwignar
Copy link
Collaborator

rjwignar commented Feb 9, 2024

@humphd Thanks for reminding me.
I hadn't checked this issue in a while and thought it also required shipping github-to-sops to ChatCraft, but I re-read the issue and everything's been completed. We can close it

@rjwignar rjwignar closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants