Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the sidebar to eliminate duplication #457

Closed
Amnish04 opened this issue Feb 15, 2024 · 0 comments · Fixed by #463
Closed

Refactor the sidebar to eliminate duplication #457

Amnish04 opened this issue Feb 15, 2024 · 0 comments · Fixed by #463
Assignees
@Amnish04
Milestone
Release 1.4

Comments

@Amnish04
Copy link
Collaborator

Amnish04 commented Feb 15, 2024 •
edited
Loading

As a follow up for #437

We need to eliminate any unnecessary code duplication introduced by the latest styling of sidebar as mentioned at #437 (review)

As far as I think, it would be good to package the Sidebar functionality in its own module and expose through an API that does not break existing UI.

Maybe something like this
305206869-bb66379b-a4eb-43a8-a082-2de40e7e37a7

3d72098
@Amnish04 Amnish04 added this to the Release 1.4 milestone Feb 15, 2024
@Amnish04 Amnish04 self-assigned this Feb 15, 2024
@Amnish04 Amnish04 mentioned this issue Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Amnish04 Amnish04

Labels
None yet
Projects
None yet
Milestone
Release 1.4
Development

Successfully merging a pull request may close this issue.

Pack Sidebar in its own module tarasglek/chatcraft.org
1 participant
@Amnish04