-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better images preview behaviour #505
Comments
I was actually thinking of having the click and zoom feature inside the modal instead of completely removing the modal. |
@Amnish04 My bad, just saw the transparent background and images zoom from it's original size is great! |
@mingming-ma I was thinking of allowing the user to zoom in and zoom out the image in the image preview modal itself. I am not sure if what I've shared is the best library for our purpose, so I am looking for more. Right now I am looking at this one |
@mingming-ma I was experimenting with react-zoom-pan-pinch and it gives me this for starters. I think this one should be good for our needs as it supports mobile gestures as well. My proposal:
|
@Amnish04 I think it's great to ship this! Can you make a PR when you're satisfied ? |
@humphd suggested in today's triage that we can rather open the image in a new tab rather than implementing zoom and pulling a new library |
As discussed in #493 (comment), we could use better lib such as react-medium-image-zoom to get enhanced images preview vs the image modal popup.
The text was updated successfully, but these errors were encountered: