Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PasswordInput component refactor #553

Closed
kliu57 opened this issue Apr 3, 2024 · 1 comment · Fixed by #582
Closed

PasswordInput component refactor #553

kliu57 opened this issue Apr 3, 2024 · 1 comment · Fixed by #582
Assignees
Milestone

Comments

@kliu57
Copy link
Collaborator

kliu57 commented Apr 3, 2024

For discussion

Right now we are taking a single inputSize param in PasswordInput component.

When it is "sm", then we make the padding/sizes/colors to match the small password input field that we currently use in the providers table.

When the param is not specified, we make the padding/sizes/color to match our regular password input field we use in instructions page.

Proposed by @Amnish04 that instead of hardcoding all the prop values like size, padding, color, etc, that we all all those props to the PasswordInput component so that it can be dynamically altered.

@Amnish04
Copy link
Collaborator

Amnish04 commented Apr 3, 2024

Associated Discussion --> #530 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants