Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error alert toast bug #586

Closed
kliu57 opened this issue Apr 12, 2024 · 0 comments · Fixed by #595
Closed

Error alert toast bug #586

kliu57 opened this issue Apr 12, 2024 · 0 comments · Fixed by #595
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kliu57
Copy link
Collaborator

kliu57 commented Apr 12, 2024

A new bug was introduced from commit 654ee24 from pr #577

Commits in order by date:

Tested these listed commits using git checkout commitCode and then pnpm dev
Using the preview url is not reliable (perhaps because the preview url only had the branch code and not the merged main code)

Steps to reproduce bug:

  1. Open User Settings Modal
  2. Set OpenAI api key to a valid key and also set it to your current provider
  3. Close User Settings Modal by clicking out
  4. Open User Settings Modal
  5. Change to api key to something invalid like, "a"
  6. Wait until validation is done, telling you its invalid
  7. Close User Settings Modal by clicking out
  8. Open User Settings Modal and change the key to a valid key

Expected Result:

Key validation is successful. And when you send a message to chatgpt it is fine. No odd behaviour.

Actual result:

You get two error alert toasts before the validation even completes. Then the validation completes successfully.
And when you send a message to chatgpt, the message sends fine and chatgpt replies fine, but you also get many error alert toasts saying your api key is wrong and your api key is "a".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants