Add functional tests and small refactorings #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jruby don't support UDP reconnection.
|
@taichi are you looking at using nio4r? |
|
@tarcieri yep. i already see nio4r. |
|
@taichi cool, if you're interested in using it let me know, I'd be happy to help |
repeatedly
added a commit
that referenced
this pull request
Mar 10, 2015
Add functional tests and small refactorings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JRuby support is very hard work for me.
So I wrote current specs using rspec.
please review the specs.
This PR doesn't contain breaking changes.
But contains few little refactoring.
JRuby support codes will be pass there specs.