New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CSVY writer from custom abundance widget to io #1927
Comments
Hello , where exactly in the io module do you want this to be moved over to ? |
Either in the same folder with the reader, or a new sub-module with writers. Be aware, the csvy writer needs to be rewritten a little to make sure it is independent of the widget. |
Hello @Rodot- Is this issue still open? If yes, I'm willing to contribte. |
Yes, I believe it is technically still open though there is currently an old PR for this still open so it might be good to try another issue until we decide if we want to close the current open PR on this. I'll ping the reviewers for it to find out and let you know! |
Hi @Rodot- can I take this up? I see the earlier PR related to this issue was closed without merging. |
Is your feature request related to a problem? Please describe.
Would be nice to have simpler access to the csvy writer for general model creation. Currently it is a part of the custom abundance widget, but the tool is generally useful.
Current location:
tardis/tardis/visualization/widgets/custom_abundance.py
Line 1384 in e1181bd
Describe the solution you'd like
Move this over to the io module to make access easier.
The text was updated successfully, but these errors were encountered: