Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time_of_simulation for j_blues and continuum process rates is from the wrong iteration #2468

Open
chvogl opened this issue Nov 10, 2023 · 0 comments

Comments

@chvogl
Copy link
Contributor

chvogl commented Nov 10, 2023

Describe the bug
The time of simulation in the plasma seems to be the value for the next iteration. However, the value from the previous iteration (in which the estimators were recorded) should be used to calculate j_blues and continuum process rates (like gamma, alpha_stim) from the estimators. In the case of the continuum estimators, the time of simulation is also not updated in the plasma since t_inner is not included in the update_properties.

update_properties.update(

To Reproduce
Run the code with a variable T_inner (and therefore time of simulation) and either the detailed radiation field treatment or continuum processes enabled.

@chvogl chvogl changed the title Time_of_simulation for j_blues and continuum process rates are taken from the wrong iteration Time_of_simulation for j_blues and continuum process rates is from the wrong iteration Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant