Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write missing test in test_montecarlo.py #2495

Open
TanviPooranmal opened this issue Dec 18, 2023 · 1 comment
Open

Write missing test in test_montecarlo.py #2495

TanviPooranmal opened this issue Dec 18, 2023 · 1 comment

Comments

@TanviPooranmal
Copy link

I think the following test needs to be written or needs to be assessed to keep or not:

def test_compute_distance2boundary(packet_params, expected_params):
mu = packet_params["mu"]
r = packet_params["r"]
r_inner = np.array([6.912e14, 8.64e14], dtype=np.float64)
r_outer = np.array([8.64e14, 1.0368e15], dtype=np.float64)
d_boundary = r_packet.calculate_distance_boundary(
r, mu, r_inner[0], r_outer[0]
)
assert_almost_equal(d_boundary[0], expected_params["d_boundary"])
#
#
# TODO: split this into two tests - one to assert errors and other for d_line

@Knights-Templars
Copy link
Member

Can you put more details on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants