Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please port to Python3.12 #164

Closed
tillea opened this issue Jan 15, 2024 · 3 comments
Closed

Please port to Python3.12 #164

tillea opened this issue Jan 15, 2024 · 3 comments

Comments

@tillea
Copy link

tillea commented Jan 15, 2024

I tried to upgrade the Debian molotov package in Debian where at the same time we want to support Python3.12. Unfortunately the test suite is running into two failures which you can find here in the full build log.
Kind regards, Andreas.

@n1ngu
Copy link
Collaborator

n1ngu commented Jan 18, 2024

That was already implemented in #153 🤔

Could that failure be due to some flaky test or some of your test suite configuration? Can you reproduce locally? (checking this repo out and running tox -e py312 works just fine for me)

@n1ngu
Copy link
Collaborator

n1ngu commented Jan 18, 2024

tox -e py312 also works in your fork, despite the fair amount of patches that you have on top of the upstream molotov. So I'd look into some CI runner configuration.

I'll close the issue because I don't see how we can help you, don't hesitate to ask for more help if something more concrete comes to your mind. Note python 3.12 IS supported.

Also, some of those patches of yours may deserve being merged upstream so be welcome to try to open a PR to reduce the burden of keeping your fork in sync.

Cheers.

@n1ngu n1ngu closed this as completed Jan 18, 2024
@tillea
Copy link
Author

tillea commented Jan 18, 2024

Thank you for your investigation into this issue. I admit I'm not the maintainer of this package, just a team member who was trying to hunt down some random Python3.12 problems. So I'll leave it to the actual Uploader of the Debian package whether he might create some PRs about this. Since the patches all are just excluding some tests its not really astonishing that the patches do not affect the test suite in a negative manner. For the moment I've added another patch excluding the two patches that were topic of this issue.
Kind regards, Andreas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants