Fix error handling for caching of stream responses

qvest-digital · Jul 11, 2016 · f0d05ba · f0d05ba
1 parent c3f7411
commit f0d05ba
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/composition/cache_loader.go b/composition/cache_loader.go
@@ -36,12 +36,14 @@ func (loader *CachingContentLoader) Load(fd *FetchDefinition) (Content, error) {
 			if c.Reader() != nil {
 				var streamBytes []byte
 				streamBytes, err = ioutil.ReadAll(c.Reader())
-				cw := &ContentWrapper{
-					Content:     c,
-					streamBytes: streamBytes,
+				if err == nil {
+					cw := &ContentWrapper{
+						Content:     c,
+						streamBytes: streamBytes,
+					}
+					loader.cache.Set(hash, fd.URL, c.MemorySize(), cw)
+					c.SetReader(cw.Reader())
 				}
-				loader.cache.Set(hash, fd.URL, c.MemorySize(), cw)
-				c.SetReader(cw.Reader())
 			} else {
 				loader.cache.Set(hash, fd.URL, c.MemorySize(), c)
 			}