Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service discovery #21

Merged
merged 8 commits into from
Jul 27, 2016
Merged

Service discovery #21

merged 8 commits into from
Jul 27, 2016

Conversation

b00lduck
Copy link
Contributor

  • DiscoveredBy decorator for fetch definitions
  • discoveredBy attribute for tag
  • fixed typos

@b00lduck b00lduck closed this Jul 27, 2016
@b00lduck b00lduck reopened this Jul 27, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 92.251% when pulling 39624d5 on service-discovery into 1cf43da on master.

ErrHandler ErrorHandler
CacheStrategy CacheStrategy
ServiceDiscoveryActive bool
ServiceDiscovery servicediscovery.ServiceDiscovery
//ServeResponseHeaders bool
//IsPrimary bool
//FallbackURL string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comments

@coveralls
Copy link

coveralls commented Jul 27, 2016

Coverage Status

Coverage decreased (-1.3%) to 92.245% when pulling 04d322d on service-discovery into 1cf43da on master.

@coveralls
Copy link

coveralls commented Jul 27, 2016

Coverage Status

Coverage decreased (-1.3%) to 92.245% when pulling 04d322d on service-discovery into 1cf43da on master.

@domano
Copy link
Contributor

domano commented Jul 27, 2016

+1 (if the CI build succeeds ;) )

@coveralls
Copy link

coveralls commented Jul 27, 2016

Coverage Status

Coverage decreased (-0.7%) to 92.852% when pulling 15d7ac1 on service-discovery into 1cf43da on master.

@coveralls
Copy link

coveralls commented Jul 27, 2016

Coverage Status

Coverage decreased (-0.4%) to 93.122% when pulling cc53808 on service-discovery into 1cf43da on master.

@b00lduck b00lduck merged commit e74b5bd into master Jul 27, 2016
@domano domano deleted the service-discovery branch July 29, 2016 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants