Enabled HEAD requests + refactoring #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deberth
commented
Nov 21, 2016
deberth
commented
- enabled head requests
- refactored servehttp method from composition handler
- go format
* refactored servehttp method from composition handler * go format
smancke
reviewed
Nov 21, 2016
| if res.Content.HttpStatusCode() >= 300 && res.Content.HttpStatusCode() <= 308 { | ||
| copyHeaders(res.Content.HttpHeader(), w.Header(), ForwardResponseHeaders) | ||
| w.WriteHeader(res.Content.HttpStatusCode()) | ||
| if agg.handleForwardingRequests(res, w, r) { |
There was a problem hiding this comment.
The name is IMO not self explaining: what's about handle30xResponses()
| w.WriteHeader(res.Content.HttpStatusCode()) | ||
| io.Copy(w, res.Content.Reader()) | ||
| res.Content.Reader().Close() | ||
| if agg.handleRequestsWithBody(res, w, r) { |
There was a problem hiding this comment.
Here, I would suggest the name: handleStreamResponses
It would also be a good idea to put both cases within the loop in one method with the name:
handleNonMergeableResponses()
| @@ -83,31 +81,83 @@ func (agg *CompositionHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) | |||
| } | |||
| } | |||
|
|
|||
| status := 200 | |||
| status := agg.extractStatusCode(results, w, r) | |||
There was a problem hiding this comment.
Also this function name is missleading, because the basic work it does is to copy the headers.
Maybe the two things: Extraction of the status code and copy the header should be done in separate steps.
* go format
|
Cool, looks very clean and understandable, now! |
This was referenced Nov 21, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.