Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Set-Cookies for all responses #32

Merged
merged 4 commits into from
Nov 22, 2016
Merged

Allow Set-Cookies for all responses #32

merged 4 commits into from
Nov 22, 2016

Conversation

smancke
Copy link
Member

@smancke smancke commented Nov 21, 2016

With this PR, it is also possible that other responses set a cookie.

The PR is based on #31, so should be merged afterwards,

dberth and others added 4 commits November 21, 2016 14:28
* refactored servehttp method from composition handler
* go format
* go format
@smancke smancke mentioned this pull request Nov 21, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 92.792% when pulling c2e32ef on allow-set-cookies-2 into d4e78f0 on master.

Copy link
Contributor

@deberth deberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Is the header field set-cookie always written case-sensitive as "Set-Cookie"? So we don't have to do something like "toLower()" in the "contains" method?

@smancke
Copy link
Member Author

smancke commented Nov 22, 2016

@deberth
Yes, the Golang http api unified the headers:
// HTTP defines that header names are case-insensitive. The
// request parser implements this by using CanonicalHeaderKey,
// making the first character and any characters following a
// hyphen uppercase and the rest lowercase.

@smancke smancke merged commit 997a9db into master Nov 22, 2016
@smancke smancke deleted the allow-set-cookies-2 branch November 22, 2016 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants