Prefer using a strategy factory to set the deduplication strategy per… #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ContentMerger. Otherwise one deduplication strategy instance is used for all ContentMerger instances, wich will cause concurrency issues and missing data, if the strategy has state.
domano
reviewed
Jun 14, 2017
| @@ -89,7 +89,10 @@ func Test_CompositionHandler_PositiveCaseWithSimpleDeduplicationStrategy(t *test | |||
| } | |||
| } | |||
| ch := NewCompositionHandler(ContentFetcherFactory(contentFetcherFactory)) | |||
| ch.WithDeduplicationStrategy(new(SimpleDeduplicationStrategy)) | |||
| sdf := func() StylesheetDeduplicationStrategy { | |||
There was a problem hiding this comment.
why sdf? sds would be more fitting (minor issue)
There was a problem hiding this comment.
stylesheet deduplication (missing strategy) factory :-)
| @@ -42,7 +42,10 @@ func compositionHandler() http.Handler { | |||
|
|
|||
| return fetcher | |||
| } | |||
| return composition.NewCompositionHandler(contentFetcherFactory).WithDeduplicationStrategy(new(composition.SimpleDeduplicationStrategy)) | |||
| sdf := func() composition.StylesheetDeduplicationStrategy { | |||
There was a problem hiding this comment.
same here, why sdf? (minor issues, naming)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… ContentMerger.
Otherwise one deduplication strategy instance is used for all
ContentMerger instances, wich will cause concurrency issues and missing
data, if the strategy has state.