Merge body attributes #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test reflects the behavior we are going to fix now. - just for documentation -
When merging attributes of the <body> Element, all existing class attributes will be merged into one. All other existing attributes will be ov overwritten by new ones.
domano
suggested changes
Aug 8, 2017
composition/interfaces.go
Outdated
| @@ -83,7 +83,7 @@ type Content interface { | |||
| Tail() Fragment | |||
|
|
|||
| // The attributes for the body element | |||
| BodyAttributes() Fragment | |||
| BodyAttributes() []html.Attribute | |||
There was a problem hiding this comment.
Breaking API change, please leave the old method and create BodyAttributesV2 or something
domano
reviewed
Aug 16, 2017
composition/interfaces.go
Outdated
| BodyAttributes() Fragment | ||
|
|
||
| // Return the attributes for the body element as array. | ||
| BodyAttributesArray() []html.Attribute |
There was a problem hiding this comment.
Still breaking the interface here
cborgolte
force-pushed
the
merge-body-attributes
branch
from
5996df6
to
4ea38de
Compare
cborgolte
force-pushed
the
merge-body-attributes
branch
from
4ea38de
to
a848b09
Compare
domano
reviewed
Aug 28, 2017
composition/content_merge.go
Outdated
| @@ -178,7 +202,12 @@ func (cntx *ContentMerge) GetBodyFragmentByName(name string) (Fragment, bool) { | |||
|
|
|||
| func (cntx *ContentMerge) AddContent(c Content, priority int) { | |||
| cntx.addHead(c.Head()) | |||
| cntx.addBodyAttributes(c.BodyAttributes()) | |||
| content2, ok := c.(Content2) | |||
There was a problem hiding this comment.
I would call it contentV2 to be clear that the naming choice is a result of a api change
composition/interfaces.go
Outdated
| @@ -99,6 +99,13 @@ type Content interface { | |||
| MemorySize() int | |||
| } | |||
|
|
|||
| type Content2 interface { | |||
There was a problem hiding this comment.
i would call it ContentV2, see above
domano
approved these changes
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue, when multiple tags are merged with identical attributes.
'class' attributes are merged together, other duplicate attributes overwrite their predecessors.