Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

lorri daemon: stop watching a project’s files after a timeout #163

Open
Profpatsch opened this issue Oct 3, 2019 · 1 comment
Open
Labels
feature request Request for new functionality P2 major: an upcoming release user-facing Improvement that increases user experience
Projects

Comments

@Profpatsch
Copy link
Collaborator

This [the lorri daemon] is done now, right?

Everything except the timeout part, which is why I haven’t closed this issue yet.

Originally posted by @Profpatsch in #65 (comment)

If the daemon runs for a long time and watches a lot of projects, it might run out of available watch handles to watch more files; this is essentially a resource leak.

We should introduce a timeout that automatically drops files from the watcher after a certain amount of time has passed without any new requests for evaluation of a nix file.

@Profpatsch Profpatsch added feature request Request for new functionality good first issue Good for newcomers P2 major: an upcoming release user-facing Improvement that increases user experience labels Oct 3, 2019
@Profpatsch Profpatsch added this to To do in lorri via automation Oct 3, 2019
@Profpatsch Profpatsch removed the good first issue Good for newcomers label Oct 3, 2019
@nyarly
Copy link
Collaborator

nyarly commented Apr 2, 2020

Related, in #365 there's a comment-in-passing about lorri stop, which might just be "expire this project immediately" (maybe the command should be lorri expire to make that clear).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request Request for new functionality P2 major: an upcoming release user-facing Improvement that increases user experience
Projects
lorri
  
To do
Development

No branches or pull requests

2 participants