Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate license files: remove License.md? #86

Closed
mbrukman opened this issue Dec 2, 2019 · 4 comments
Closed

Duplicate license files: remove License.md? #86

mbrukman opened this issue Dec 2, 2019 · 4 comments

Comments

@mbrukman
Copy link

mbrukman commented Dec 2, 2019

Looks like there are both a LICENSE as well as a License.md file in the repo. The LICENSE file is the authoritative full-length Apache license, while the License.md is the short-form version, suitable for top-of-file comment header, for example, but not a substitute for the full license.

It would be good to remove License.md since it's the short-form version, and it's currently keeping the repo from getting the automatic "Apache 2.0" license badge on the overview page courtesy of GitHub's automatic license detector, due to the presence of 2 license files.

Thanks!

@vanbenschoten
Copy link
Collaborator

@mbrukman thanks for the heads up! @frankiecancino what is Target's stance on just having the LICENSE file? Currently the repo only has the Target copyright in the License.md file: is there an updated version we could use for both?

@mbrukman
Copy link
Author

mbrukman commented Dec 2, 2019

Disclaimer: I am not a lawyer and this is not legal advice; this is just my opinion & observations.

Please don't modify the Apache 2.0 LICENSE file with a copyright annotation as it will only confuse automated tools (and will not accomplish the automated license chip on the repo overview page).

Also, as soon as you have folks beyond just one company contributing to a project, you would have to change the copyright statement from, e.g., "(c) Target" to "(c) MatrixProfile Authors" or similar, as I've seen in multiple other projects, along with an AUTHORS file to specify the authors/copyright holders.

@vanbenschoten
Copy link
Collaborator

Duplicate License.md file has been removed, so I'm closing this issue.

@mbrukman
Copy link
Author

mbrukman commented Dec 5, 2019

Thanks, @vanbenschoten!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants