Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relax commit bounds #10

Merged

Conversation

hansieodendaal
Copy link
Contributor

Relaxed commit bounds by allowing generators with more extension degrees (that remain unused) as is strictly necessary for the resulting multi-exponentiation multiplication.

Relaxed commit bounds by allowing generators with more extension degrees (that
remain unused) as is strictly necessary for the resulting multi-exponentiation
multiplication.
Copy link
Contributor

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CI benches fails with `Error: Process completed with exit code 1.`

In `benchmark.yml`
```
          fail-on-alert: true
```
and in the tests
```
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high severe
```
which could be the reason it reports a failure.
@stringhandler stringhandler merged commit 4ec07aa into tari-project:main May 31, 2022
@hansieodendaal hansieodendaal deleted the ho_relax_commit_bounds branch May 31, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants