Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support no-std environments #107

Merged
merged 3 commits into from Jan 12, 2024

Conversation

AaronFeickert
Copy link
Contributor

@AaronFeickert AaronFeickert commented Jan 9, 2024

This PR makes the library friendly to no-std environments.

It also adds a new (default) std feature that enables corresponding functionality in dependencies.

It updates tests and benchmarks to use a seeded ChaCha12-based pseudorandom number generator to ensure these don't require std or rand (which makes CI much cleaner).

Finally, it adds a wasm32-unknown-unknown CI build target to ensure everything works as expected in a no-std environment.

Supersedes #103.

Closes #102.

Copy link
Contributor

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, looking good, just some small changes please.

src/range_proof.rs Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@hansieodendaal hansieodendaal merged commit bce16c4 into tari-project:main Jan 12, 2024
7 checks passed
@AaronFeickert AaronFeickert deleted the no-std-feature branch January 12, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make std optional if feasible
4 participants