fix!: nonce index encoding #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
encoding-fix
branch
from
4e7a29d
to
618ba40
Compare
AaronFeickert
force-pushed
the
encoding-fix
branch
from
618ba40
to
b8860b2
Compare
SWvheerden
approved these changes
May 3, 2023
Merged
stringhandler
pushed a commit
that referenced
this pull request
Jul 13, 2023
Update the version ## [0.3.0](v0.2.3...v0.3.0) (2023-07-13) ## ⚠ BREAKING CHANGES * Changes the way that seed nonces are used in mask recovery. Existing range proofs will verify, but will fail to recover the correct mask. ## Features * simplify bit vector commitment ([35](#35)) ([f831d64](f831d64)), closes [/github.com/tari-project/bulletproofs-plus/blob/cd7588ee8eaebe862fe9cf5d7c3fd92981703e87/src/range_proof.rs#L265-L273](https://github.com/tari-project//github.com/tari-project/bulletproofs-plus/blob/cd7588ee8eaebe862fe9cf5d7c3fd92981703e87/src/range_proof.rs/issues/L265-L273) * use precomputation on (most) fixed generators ([19](#19)) ([cd7588e](cd7588e)), closes [#18](#18) ## Bug Fixes * nonce index encoding ([31](#31)) ([394843f](394843f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nonces used for mask recovery are generated using hashes of a label, seed, and two optional indexes. The label is included using the
personafield available inBlake2b, and the seed is of fixed length. However, the indexes areusizeand encoded in a manner that is platform dependent. This means that mask recovery on a platform with a different pointer size than the prover will fail to produce the correct mask.This work updates to use a
u32encoding, returning an error if the index exceeds this limit. This should never occur, given the typical range of indexes used. It adds tests and does some minor refactoring.Closes issue 30.
BREAKING CHANGE: Changes the way that seed nonces are used in mask recovery. Existing range proofs will verify, but will fail to recover the correct mask.