feat: simplify bit vector commitment #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
bit-vector-commitment
branch
3 times, most recently
from
872a02a
to
eaa60fa
Compare
Revert "Simplify bit vector commitment" This reverts commit eaa60fa. Test: bit vector commitment via precomputation
AaronFeickert
force-pushed
the
bit-vector-commitment
branch
from
eaa60fa
to
99bc882
Compare
Merged
stringhandler
pushed a commit
that referenced
this pull request
Jul 13, 2023
Update the version ## [0.3.0](v0.2.3...v0.3.0) (2023-07-13) ## ⚠ BREAKING CHANGES * Changes the way that seed nonces are used in mask recovery. Existing range proofs will verify, but will fail to recover the correct mask. ## Features * simplify bit vector commitment ([35](#35)) ([f831d64](f831d64)), closes [/github.com/tari-project/bulletproofs-plus/blob/cd7588ee8eaebe862fe9cf5d7c3fd92981703e87/src/range_proof.rs#L265-L273](https://github.com/tari-project//github.com/tari-project/bulletproofs-plus/blob/cd7588ee8eaebe862fe9cf5d7c3fd92981703e87/src/range_proof.rs/issues/L265-L273) * use precomputation on (most) fixed generators ([19](#19)) ([cd7588e](cd7588e)), closes [#18](#18) ## Bug Fixes * nonce index encoding ([31](#31)) ([394843f](394843f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, bit vector commitments are computed using multiscalar multiplication against the inner-product generators. However, this can be simplified by using the shiny new generator precomputation feature.