feat: refactor inner-product prover #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
nix-indexes
branch
from
c3ce1cf
to
bc2aa26
Compare
AaronFeickert
changed the title
src/range_proof.rs
Outdated
Comment on lines
329
to
333
| // Split the vectors for folding | ||
| let (a_lo, a_hi) = a_li.split_at(n); | ||
| let (b_lo, b_hi) = a_ri.split_at(n); | ||
| let (gi_base_lo, gi_base_hi) = gi_base.split_at(n); | ||
| let (hi_base_lo, hi_base_hi) = hi_base.split_at(n); |
There was a problem hiding this comment.
Suggested change
| // Split the vectors for folding | |
| let (a_lo, a_hi) = a_li.split_at(n); | |
| let (b_lo, b_hi) = a_ri.split_at(n); | |
| let (gi_base_lo, gi_base_hi) = gi_base.split_at(n); | |
| let (hi_base_lo, hi_base_hi) = hi_base.split_at(n); | |
| // Split the vectors for folding | |
| fn checked_split_at<T>(my_vec: &[T], n: usize) -> Result<(&[T], &[T]), ProofError> { | |
| if n <= my_vec.len() { | |
| Ok(my_vec.split_at(n)) | |
| } else { | |
| Err(ProofError::InvalidLength("Index out of bounds".to_string())) | |
| } | |
| } | |
| let (a_lo, a_hi) = checked_split_at(&a_li, n)?; | |
| let (b_lo, b_hi) = checked_split_at(&a_ri, n)?; | |
| let (gi_base_lo, gi_base_hi) = checked_split_at(&gi_base, n)?; | |
| let (hi_base_lo, hi_base_hi) = checked_split_at(&hi_base, n)?; |
There was a problem hiding this comment.
Doesn't this basically treat the split the same as before from a panic perspective? The slice-based version has the same issue.
There was a problem hiding this comment.
Updated in a new commit.
SWvheerden
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inner-product prover is a bit clunky, as it requires the range prover to set up a struct, perform iterative rounds, and then parse out the proof elements it needs. This also requires consistency checks that it would be nicer to avoid.
This PR moves the inner-product prover into the range prover, which simplifies things at the cost of a longer prover function.
It also fixes some vector allocations that were much bigger than necessary.
Closes #61. Closes #55. Supersedes #56.