New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: replace lazy_static
with once_cell
#69
Conversation
8a35cd4
to
7350b9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and concise, a definite improvement. Just a couple of small comments below.
There are still some assumptions that this code makes about
However, these assumptions are carefully documented, should be easy to check by inspection, are reasonably tested, and I don't see a good way to remove them without overhauling the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
42ba8fb
to
2efef29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
2efef29
to
ae86214
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Extended commitment generators are currently produced using the
lazy_static
macro. Unfortunately,lazy_static
is no longer actively maintained. Other repositories in the ecosystem are moving toonce_cell
, which is actively maintained.This PR migrates from
lazy_static
toonce_cell
. In the process, it cleans up the construction. Specifically, it moves from using word-based numbering (e.g.ONE
,TWO
) in hash inputs to numerals, which simplifies the design. It also adds a useful test that asserts the number of generators matches the size ofExtensionDegree
to avoid panics.Closes #67.
BREAKING CHANGE: Modifies the construction of commitment generators.