feat!: change to nums constants #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed NUMS constants used for the generators to make use of domain separated labels and not use iterative hashing of the Ristretto base point.
stringhandler
previously approved these changes
Jun 24, 2022
Cargo.toml
Outdated
| @@ -7,7 +7,7 @@ categories = ["cryptography"] | |||
| homepage = "https://tari.com" | |||
| readme = "README.md" | |||
| license = "BSD-3-Clause" | |||
| version = "0.13.2" | |||
| version = "0.13.4" | |||
There was a problem hiding this comment.
Don't update the version, this is done in the tagging process
There was a problem hiding this comment.
The wrong version was my mistake, I'll update it with the next tag
stringhandler
approved these changes
Jun 24, 2022
delta1
reviewed
Jun 24, 2022
| @@ -7,7 +7,7 @@ categories = ["cryptography"] | |||
| homepage = "https://tari.com" | |||
| readme = "README.md" | |||
| license = "BSD-3-Clause" | |||
| version = "0.13.4" | |||
| version = "0.13.2" | |||
There was a problem hiding this comment.
breaking change should be 0.14 ?
|
LGTM. Breaking changes need a bigger bump. Since we're pre 1.0, it should be to 0.14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change - any project based on a specific commitment in
tari_cryptoneeds to be updated, as a commitment for the same value and blinding factor will now yield a different commitment. This was a necessary change as as described below.0.13.4(this will align the version and tag as the previous version is0.13.2and the previous tag is0.13.3)