feat: functionality to work with Hidden types
#148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
changed the title
Hidden typesHidden types
|
This should be checked by @jorgeantonio21 to see if it properly addresses the issues he had. |
| hasher.update([0, 0, 0]); | ||
|
|
||
| let mut output = GenericArray::<u8, <Blake256 as Digest>::OutputSize>::default(); | ||
| hasher.finalize_into(&mut output); |
There was a problem hiding this comment.
Maybe add a new line with an assertion to compare the result of output with the same data, hashed using finalize.
| hasher.update([0, 0, 0]); | ||
|
|
||
| let mut output = GenericArray::<u8, <Blake256 as Digest>::OutputSize>::default(); | ||
| hasher.finalize_into_reset(&mut output); |
jorgeantonio21
approved these changes
Nov 11, 2022
|
Will merge once there's an ACK |
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in
tari_utilitiesPR 52 provides a newHiddentype for hidden data that supports safer handling of underlying data that supports theZeroizetrait. This is intended to handle things like passphrases, seed words, and derived key materials.Initial work by @jorgeantonio21 on migrating existing key derivation function (KDF) outputs to use
Hiddenfound two issues pretty quickly:SecretKeyandPublicKeytraits do not enforceZeroize, even though the Ristretto-based implementations in this crate do.The first issue is more of an annoyance, since it means a
Hiddentype containing a genericSecretKeyorPublicKeyneeds to add additionalZeroizetrait bounds everywhere. This PR adds the trait bound to both. SinceRistrettoSecretKeyandRistrettoPublicKeyalready implementZeroize, this change is seamless. This addresses part of issue 147.The second issue is trickier. While we can't control what goes on inside the state of any underlying hash function (e.g.
Blake256in thetaricrate), and while some hashing API use cases don't assume the output is sensitive, KDF use cases do. For these cases, we want to minimize non-zeroized copies of the output. This PR mitigates this by implementingFixedOutputforDomainSeparatedHasher, which adds in-place output support. The use of the requiredfinalize_into_resetmight be helpful in this case, since it doesn't consume the hasher but resets its internal state (albeit in a way that isn't clear to me).