fix: make schnorr sig impls apply for any hash domain #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
changed the title
sdbondi
changed the title
stringhandler
previously approved these changes
Nov 23, 2022
This comment was marked as resolved.
This comment was marked as resolved.
|
Will fix this one for now though and we can discuss |
sdbondi
force-pushed
the
impl-signature-for-any-hash-domain
branch
2 times, most recently
from
d15bd22
to
cc81105
Compare
sdbondi
force-pushed
the
impl-signature-for-any-hash-domain
branch
from
cc81105
to
226cd3e
Compare
sdbondi
force-pushed
the
impl-signature-for-any-hash-domain
branch
from
226cd3e
to
cc2bd54
Compare
CjS77
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All impls for
SchnorrSignatureonly applied to the SchorrSigChallenge hash domain.This PR fixes that by implementing them for any hash domain