fix: use updated range proof API #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
range-proof-api
branch
2 times, most recently
from
f3cfb7d
to
e94b71d
Compare
AaronFeickert
force-pushed
the
range-proof-api
branch
from
81c1812
to
192c4e1
Compare
AaronFeickert
force-pushed
the
range-proof-api
branch
from
192c4e1
to
397a72f
Compare
stringhandler
approved these changes
Jan 4, 2023
| match RistrettoRangeProof::verify_do_not_recover_masks(self.transcript_label, &[statement], &[ | ||
| rp.clone() | ||
| ]) { | ||
| match RistrettoRangeProof::verify_batch( |
There was a problem hiding this comment.
I'm not a fan of returning different data based on the action, but I think that's subjective, so think it's fine
stringhandler
pushed a commit
to tari-project/tari
that referenced
this pull request
Jan 4, 2023
Description --- Updates `tari-crypto` dependencies to use range proof batch splitting. Motivation and Context --- An [earlier PR](#5049) removed an unnecessary restriction on range proof batch splitting. Recent `bulletproofs-plus` work [updates range proof batching](tari-project/bulletproofs-plus#22) to split large batches for performance reasons, and also updates the verification API for clarity. A [corresponding PR](tari-project/tari-crypto#160) in `tari-crypto` uses this new API, but does not change its own external range proof verification API. This PR updates `tari-crypto` dependencies to take advantage of this new functionality. How Has This Been Tested? --- Existing tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a new range proof API.