feat: require secret keys to be zeroized on drop #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
zeroize-on-drop
branch
from
2b2da71
to
bd29bee
Compare
|
This should be tested on the main |
stringhandler
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a trait bound requiring that a
SecretKeyzeroize on drop. Derives this trait bound forRistrettoSecretKey.Currently, we use a macro from
zeroizeto zeroize aRistrettoSecretKeyon drop. This works fine, but doesn't let us require this behavior as aSecretKeytrait bound. Now that we have a custom curve library fork that supports an updated version ofzeroize, we can take advantage of a newZeroizeOnDropderive macro that adds a corresponding marker trait. This PR adds the marker trait as a trait bound toSecretKeyand uses the derive macro forRistrettoSecretKey. This adds an additional layer of safety to secret keys.Closes issue #147.