JavaScript-Capstone-project #38
Conversation
There was a problem hiding this comment.
APPROVED 🟢
Hi Team,
Congrats on finishing your capstone project from the first try! Your project now is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- Great job setting up the correct linters ✔️
- Highly organized and clean code ✔️ 👨🏻💻
- Professional documentation ✔️
- Correct workflow ✔️
- Meaningful commit messages ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| ## Live demo | ||
| [Ckick here]( https://tarikbouari.github.io/GameLand/) |
There was a problem hiding this comment.
[OPTIONAL]
- This link isn't working kindly add a working live demo link, because you'll use this project in the future to show your portfolio!
src/modules/itemCounter.js
Outdated
| export default async function gamecount() { | ||
| const data = await getGame(); | ||
| const count = data.length; | ||
| console.log(count); |
There was a problem hiding this comment.
[OPTIONAL]
- Kindly remove any console messages before merging this into dev, it shouldn't include any console logs.
In this project we :
Here is the link to the video