Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout #36

Closed
sobiso opened this issue Jun 14, 2018 · 4 comments
Closed

Logout #36

sobiso opened this issue Jun 14, 2018 · 4 comments

Comments

@sobiso
Copy link

sobiso commented Jun 14, 2018

OK that me... again ;)
Flow -> go to page -> signIn -> dashbard -> signOut
Why i no go back to LandingPage ? Even i put url without any string after "/" ?

@sobiso sobiso closed this as completed Jun 14, 2018
@TarikHuber
Copy link
Owner

hi @sobiso
It is absolutely no problem to write issues here 😄
I'm happy that you are interested in the project and have such good questions.

The landing page is for the very first visit so only on the first visit it will/should be shown.

Why did you close the issue?

@sobiso
Copy link
Author

sobiso commented Jun 14, 2018

Because I found that on LandingPage is

if (!this.isAuthorised()) {
     history.push('/signin')
  }

so user was redirect to 'signin' page

@sobiso
Copy link
Author

sobiso commented Jun 15, 2018

Can we add some button/text/link whatever to go to landing page( or some other page) after logout ?

@TarikHuber
Copy link
Owner

I'm open for PRs. Just keep in mind that the Landing Page has to be extremely fast ;) for the Lighthouse test. That is the only reason I created it 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants