Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions #95

Closed
ghost opened this issue Feb 9, 2014 · 11 comments
Closed

Suggestions #95

ghost opened this issue Feb 9, 2014 · 11 comments

Comments

@ghost
Copy link

ghost commented Feb 9, 2014

This is awesome, but I have some suggestions.

  1. I prefer the dynamic index file (PHP) so that one can add scripts...
  2. All CSS, JS and fonts should hosted locally. My application involves intranet with no access to the outside.
    Thanks a lot!
@commonquail
Copy link
Contributor

Isn't number 2 already the case? I'm not sure about fonts but I opened a now-closed issue a few days ago specifically to address that point. If there are online fonts being used that should be changed.

@ghost
Copy link
Author

ghost commented Feb 9, 2014

#2 -- Never mind. Happy to know!!!

@commonquail
Copy link
Contributor

I just checked, there are a few font dependencies. I'm guessing the browser'll just fall back to a default but we should get rid of it anyway.

@tariqbuilds
Copy link
Owner

What type of script do you wish to add to the index file? I would like to keep the index file HTML but am always open to suggestions. Maybe we can find a way to accommodate your intent without going to back-end file format like PHP.

@ghost
Copy link
Author

ghost commented Feb 10, 2014

While using pure HTML may be good for some users (if they don't have PHP
installed), it may be good to offer the option to have the index file
also as PHP.

Here are the scripts that I added to the index file. This provides me
with additional useful information:

Your IP address: '.$_SERVER['REMOTE_ADDR'].' ('.gethostbyaddr($_SERVER['REMOTE_ADDR']).')
Server '.$_SERVER["SERVER_SOFTWARE"].'
PHP ' . phpversion().'
'.OPENSSL_VERSION_TEXT; ?>

This is just an example. I am using this in my highly customised NGINX
server that has some extra variables.
I am using this on my intranet with local DNS server.
But this is a good illustration of what can be useful.

On 2014-02-10 10:41, Afaq Tariq wrote:

What type of script do you wish to add to the index file? I would like
to keep the index file HTML but am always open to suggestions. Maybe
we can find a way to accommodate your intent without going to back-end
file format like PHP.


Reply to this email directly or view it on GitHub
#95 (comment).

@ghost
Copy link
Author

ghost commented Feb 10, 2014

Ok, I am using the latest version now. The page still loads resources from the internet, like the fonts, bootstrap and other stuff.

@tariqbuilds
Copy link
Owner

I can see the font-awesome fonts being loaded external (which we will remove) but I did not see any other css/js/asset being loaded externally, except the github "fork me" banner.

Could you point me to which "bootstrap and other stuff" files are being loaded externally? I'd like to remove those dependencies.

@tariqbuilds
Copy link
Owner

@peterkahl - Your scripting needs for data from PHP seem to fit solution architecture the application has for the widget data: separate, modularized PHP files in the sh directory which the dashboard.js retrieves info from via AJAX and loads into DOM. This helps keep the application structured, easy to debug, and easy to contribute to horizontally or vertically (widget vs. application).

@ghost
Copy link
Author

ghost commented Feb 10, 2014

Scripting. Makes sense. Now looking for having the information on which versions of various packages installed. Thanks.

@tariqbuilds tariqbuilds added this to the General code improvements milestone Feb 11, 2014
@ghost
Copy link
Author

ghost commented Feb 13, 2014

The file
css/google-fonts.css
has links to
https://themes.googleusercontent.com/

The file index.html
sources image externally
Fork me on GitHub
This should be local image.

That's all I was able to find.

@tariqbuilds
Copy link
Owner

Addressed both issues in a push. Thanks, @peterkahl .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants