HttpCompression Not Checking for Already Compressed Content

[josh-sachs]

Another middleware exists in my pipeline that serves bundled/gziped script and css resources https://github.com/Shazwazza/Smidge

The middleware sets Content-Encoding = gzip since it knows the content it is delivering has already been gziped and cached to disk.

WebMarkupMin does not appear to check the response headers for existing compression before applying its own compression (defaulting to deflate).

I think that if the Content-Encoding header has already been set further down in the pipeline, the WebMarkupMin HttpCompression middleware should be skipped.

In this scenario, content decoding fails at the browser.

Thoughts?

[Taritsyn]

Hello, Kudoz83!

In WebMarkupMin 2.2.0 fixed this error.

Thanks for information!

[Taritsyn]

Additionally, this hotfix prevents the occurrence of strange error messages:

Category: HTML_PARSING_ERROR
Message: In the start tag <y> found invalid characters.
File: /
Line number: 2
Column number: 41
Source fragment:

Line 1: ������`�I�%&/m�{�J�J��t���`�$ؐ@��������iG#)�*��eVe]f�@�흼��{���{���;�N'���?\fd�l��J�ɞ!����…
Line 2: ��4-��� ��2r�G�!搱R����<^f1�����8,���F��Fn ��wP�z�W����I��    ��_�
------------------------------------------------^
Line 3: �.����������[�y|7N��[v?������ԅ�v�+�YN5̝g��g~k���� ����u��⨒����x����*xL��F���}Q͊�봝�M��U��y�V�O�…

Now, instead of it, displays a more understandable error messages:

Can not apply markup minification to text content, that was encoded in the 'gzip' format.

[5arif]

hi i get error

Can not apply markup minification to text content, that was encoded in the 'gzip' format.

in azure but work fine in my local server, i use 2.2.2 version in my mvc app <package id="WebMarkupMin.AspNet4.Mvc" version="2.2.2" targetFramework="net462" /> please help

[Taritsyn]

Hello, Sarif!

I recommend you to read the “At what point in the run-time process does IIS compress output?” discussion on Stack Overflow.

[Taritsyn]

Hello, Sarif!

You deleted own post? Perhaps you have had a problem with the quotes?

[5arif]

yes i deleted it,. it already working ,. i add

dynamicCompressionBeforeCache="false"

in my web config i just wondering is it possible to handle it from code,.
is it possible to implement compression in json response,. ?

[Taritsyn]

is it possible to implement compression in json response,. ?

@5arif Add a CompressContent attribute to the action method, that returns JSON data.

Also I recommend you to upgrade to version 2.4.0 (there were solved many problems related with HTTP compression).