Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for starlette 0.16 #154

Merged
merged 4 commits into from Aug 7, 2021

Conversation

siopaonow
Copy link
Contributor

@siopaonow siopaonow commented Aug 5, 2021

Closed #157

Update requirements to support starlette 1.6. Type checks are failing, but are resolved in #150.

Minor adjustment required for test, due to the starlette 1.5 release: https://github.com/encode/starlette/releases/tag/0.15.0

TestClient.websocket_connect() now must be used as a context manager.

setup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siopaonow Looking good, thank you!

@florimondmanca florimondmanca merged commit 5a80b4f into tartiflette:master Aug 7, 2021
@florimondmanca florimondmanca changed the title Add support for starlette 1.6 Add support for starlette 0.16 Aug 7, 2021
@aljinovic
Copy link
Contributor

Hi, any ETA for release maybe?

@florimondmanca
Copy link
Contributor

@aljinovic Fair call, I believe we were only waiting on #155 but that's an incremental addition which we can roll out with later. I'm only around starting next week, I can add someone to the repo and walk through release details if need be (we've got some instructions in the CONTRIBUTING guide already though, I think?).

@florimondmanca
Copy link
Contributor

I guess anyone interested in an earlier release could give a go at a release PR, based on the contributing guide and previous release PRs.

@aljinovic aljinovic mentioned this pull request Aug 27, 2021
@aljinovic
Copy link
Contributor

PR created: #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for latest starlette release
4 participants