Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect when the app has been idle for a bit and generate an account only if the user has used the app enough #188

Open
pcowgill opened this issue Mar 22, 2019 · 5 comments
Labels
enhancement New feature or request
Projects
Milestone

Comments

@pcowgill
Copy link
Member

(Or do this as a background task)

@pcowgill pcowgill added this to To do in Main via automation Mar 22, 2019
@pcowgill pcowgill added this to the 0.2.0 release milestone Mar 22, 2019
@pcowgill pcowgill added the enhancement New feature or request label Mar 22, 2019
@pcowgill pcowgill changed the title Detect when the app has been idle and for a bit and generate a wallet then if the user has used the app enough Detect when the app has been idle and for a bit and generate an account then if the user has used the app enough Mar 22, 2019
@pcowgill pcowgill changed the title Detect when the app has been idle and for a bit and generate an account then if the user has used the app enough Detect when the app has been idle for a bit and generate an account then if the user has used the app enough Apr 12, 2019
@pcowgill pcowgill changed the title Detect when the app has been idle for a bit and generate an account then if the user has used the app enough Detect when the app has been idle for a bit and generate an account only if the user has used the app enough Apr 18, 2019
@pcowgill
Copy link
Member Author

@marcelomorgado In the long run, I do think we want to detect when the app has been idle for a bit and generate an account only if the user has used the app enough. In the short run, it might show off our simple onboarding flow better if we had this happen behind the scenes while they were browsing land.

If you agree, let's make another issue for that.

Would the account generation step block the user from scrolling on the land screen as it works right now?

@marcelomorgado
Copy link
Contributor

  1. To clarify: Should we create a short-term issue to trigger the account set up on the app startup?
  2. Not sure, I theory if we wrap the account creation process with an async function it should run in the background. But maybe it'll block the user during the 20segs of generation step (Account.create()), even that happens we can try some trick to solve that.

@pcowgill
Copy link
Member Author

1a. Either that or make it manually triggerable from the My profile screen.

1b. Maybe we decouple account generation and funding too? Open to your creative input here.

1c. I wonder if all of the funding happening behind the scenes sets unreasonable expectations for the "real" flow we'll eventually use. Maybe not if the account is funded with some tokens used to pay for a few meta-tx, anyway. But having MANA may be unrealistic.

  1. Okay yes, let's test specifically this before committing to having this happen on app startup. Triggering it on app startup shouldn't block the loading screen, and if it affects scrolling performance, etc. we wouldn't want to go that route.

@marcelomorgado
Copy link
Contributor

1a. Makes sense;
1b, 1c. Since without expo-crypto, the account generation is spending about 20secs of waiting, sounds good to me decouple these steps and trigger the generation on the startup (if that not impacts the UX performance).
2. We can make some tryouts on that. As the first step, we can try to move the Account.create() from sign-up flow to start up.

Make sense?

@pcowgill
Copy link
Member Author

1b, 1c. Okay, awesome. FYI on my iPhone X it's a little faster than that.

  1. Okay. yep, let's try a tentative PR with just that change.

Sounds good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Main
  
To do
Development

No branches or pull requests

2 participants