-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify and speed up docker build #1084
Conversation
It yells at you and is actually unnecessary due to https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. I'm not 100% clear on why it would be faster (did it maybe have to pull the node images in the first run?) but hey, it's not slower :)
It is kinda hidden but the speedup comes from setting |
Reorder docker build steps to skip yarn install if no change
This simplifies our usage of docker somewhat by shelling out to the cli. While I was at it, I enabled buildkit.
Old Style
Buildkit
Unscientifically this is a ~6 minute speed up.
It seems to run just fine on my dev deployment.