Use kubectl to interact with dev clusters #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbstack
force-pushed
the
better-dev-deploys
branch
from
e93a42c
to
ebbde68
Compare
edunham
reviewed
Jul 25, 2019
| provides: ['target-templates'], | ||
| run: async (requirements, utils) => { | ||
| let command = ['helm', 'template']; | ||
| if (requirements['helm-version'] === 3) { |
There was a problem hiding this comment.
does this allow configuring to pick a helm version? if so, could you drop a note about it in the docs somewhere?
There was a problem hiding this comment.
Doesn't allow configuring, it just works with whatever helm you have installed (2 or 3, who knows about 1). I'll mention in the docs though how this works
owlishDeveloper
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow redeploying the cluster without uninstalling first!
It should also be faster and more verbose about what it is doing.