Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup configs and make them understandable #1190

Merged
merged 12 commits into from
Aug 16, 2019
Merged

Cleanup configs and make them understandable #1190

merged 12 commits into from
Aug 16, 2019

Conversation

imbstack
Copy link
Contributor

As it says on the tin

@imbstack imbstack changed the title [WIP] Cleanup configs and make them understandable Cleanup configs and make them understandable Aug 15, 2019
@imbstack imbstack marked this pull request as ready for review August 15, 2019 21:15
@imbstack imbstack requested review from a team as code owners August 15, 2019 21:15
djmitche
djmitche approved these changes Aug 16, 2019
View reviewed changes
Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I suspect there's more, but this is a great start.

This doesn't deserve a major version bump, but should have a changelog entry mentioning the removed configuration

services/hooks/config.yml Show resolved Hide resolved
dev-docs/dev-config-example.yml Show resolved Hide resolved
@imbstack imbstack merged commit 11491b8 into master Aug 16, 2019
@imbstack imbstack deleted the cleanup-configs branch August 16, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djmitche djmitche djmitche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imbstack @djmitche