Google provider cleanup part 1 #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owlishDeveloper
approved these changes
Aug 30, 2019
| this.configSchema = 'config-google'; | ||
|
|
||
| this.instancePermissions = instancePermissions; | ||
| assert(project, 'Must provide a project to google providers'); |
There was a problem hiding this comment.
excellent! I should add some assertions like this to aws provider as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the ability for google provider to set up its own service accounts for workers. This both simplifies the code significantly and makes worker-manager much safer to run! Couple of other QOL improvements here as well. Part 2 should be coming soon where we clean up a few last TODOs and add some rate limiting logic.