Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aws-provisioner support from UI #1576

Closed
djmitche opened this issue Oct 11, 2019 · 5 comments · Fixed by #1650
Closed

Remove aws-provisioner support from UI #1576

djmitche opened this issue Oct 11, 2019 · 5 comments · Fixed by #1650
Assignees
Labels

Comments

@djmitche
Copy link
Collaborator

djmitche commented Oct 11, 2019

Reserved for outreachy candidates. In order for this to be assigned to you, make sure to complete the first step of the application process outlined in the project description.


The "AWS Provisioner" component will no longer have anything to talk to as of November 9. Let's remove it. This involves:

  • removing from the navigation menu
  • removing the view and any associated components
  • removing the aws-provisioner-related GraphQL queries from the web-server service
@helfi92 helfi92 added good first issue Good for newcomers outreachy labels Oct 11, 2019
@helfi92
Copy link
Contributor

helfi92 commented Oct 11, 2019

Anything under /aws-provisioner belongs to the aws-provisioner. https://taskcluster-ui.herokuapp.com/aws-provisioner.

@kellim
Copy link
Contributor

kellim commented Oct 11, 2019

I'm an Outreachy candidate who completed the first step of the application process. Can you assign this to me please?

@kellim
Copy link
Contributor

kellim commented Oct 15, 2019

@helfi92 I was looking to see if there was a pull request for when AWS Provisioner was added so I could figure out everything that needs to be removed, but instead I found one where it was removed already- https://github.com/taskcluster/taskcluster/pull/929/files
It looks like those changes are no longer in the repo, and that pull request also had some code for Provisioners too, which looks like you don't want removed at this time.

Would that pull request linked above be the best guide I can use for code to remove -- only removing what's related to AwsProvisioner and not Provisioner?

@djmitche
Copy link
Collaborator Author

See the comments on that PR -- the aws-provisioner view is now OK to remove (worker-manager is in production) but the provisioners view should stay.

@helfi92
Copy link
Contributor

helfi92 commented Oct 15, 2019

We previously removed the /aws-provisioner and /provisoners views but reverted the change a day or two later. We are now ready to remove the /aws-provisioner view but not /provisioners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants