Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web-server] CORS for TPL endpoints #1665

Closed
helfi92 opened this issue Oct 16, 2019 · 3 comments · Fixed by #1666
Closed

[web-server] CORS for TPL endpoints #1665

helfi92 opened this issue Oct 16, 2019 · 3 comments · Fixed by #1666
Assignees
@helfi92
Labels
bug Something isn't working

Comments

@helfi92
Copy link
Contributor

helfi92 commented Oct 16, 2019

CORS is only configured for the rootUrl. We should configure CORS for third party login endpoints. We can get the origins from the registered clients redirect URI field.
@helfi92 helfi92 added bug Something isn't working web-server labels Oct 16, 2019
@helfi92 helfi92 self-assigned this Oct 16, 2019
@helfi92 helfi92 mentioned this issue Oct 16, 2019
Merged
@djmitche
Copy link
Collaborator

I'm curious what the lack of CORS breaks.. I thought CORS was only for XHR requests?

@helfi92
Copy link
Contributor Author

helfi92 commented Oct 17, 2019

Our current endpoints only work for requests made from the taskcluster UI so /login/oauth/token and /login/oauth/credentials (called from third party sites) won't work. Does that help answer your question?

@djmitche
Copy link
Collaborator

Ah, yes -- those are indeed accessed with XHR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@helfi92 helfi92

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configure CORS for TPL endpoints helfi92/taskcluster
2 participants
@djmitche @helfi92