Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task name is mangled in task view page title #1881

Closed
SimonSapin opened this issue Nov 4, 2019 · 6 comments · Fixed by #1915
Closed

Task name is mangled in task view page title #1881

SimonSapin opened this issue Nov 4, 2019 · 6 comments · Fixed by #1915
Assignees
Labels
good first issue Good for newcomers

Comments

@SimonSapin
Copy link
Contributor

In https://community-tc.services.mozilla.com/tasks/W3MxM2o_Tw24Nz7oM8LtLw we see

Servo: macOS x64: WPT chunk 6 / 6 + extra

(which is correct), and above that and in the tab’s title:

Servo Mac Os X64 Wpt Chunk 6 6 Extra

Similarly in https://community-tc.services.mozilla.com/tasks/UxQR1tHSRN6imKedMGQGsQ/

Servo: Android ARMv7: Dev build

… becomes:

Servo Android Ar Mv7 Dev Build

I would be nice if we could disable this mangling.

@djmitche
Copy link
Collaborator

djmitche commented Nov 4, 2019

/cc @lissyx

@helfi92 helfi92 added the good first issue Good for newcomers label Nov 4, 2019
@naima-shk
Copy link
Contributor

@SimonSapin May i get this issue ? :)

@naima-shk
Copy link
Contributor

@helfi92 Thank you :)

@helfi92
Copy link
Contributor

helfi92 commented Nov 4, 2019

You'll want to use

/**
* If true, the title will not be formatted to uppercase.
*/
disableTitleFormatting: bool,

@naima-shk
Copy link
Contributor

@helfi92 I started looking into the issue and saw we have this logic "const pageTitle = disableTitleFormatting ? title : makeTitle(title);" and when we take the title "test-linux64/debug-mochitest-e10s-15" and format it, it converts to "Test Linux64 Debug Mochitest E10s 15". My question is should I not format the Task title in the header or update the formatting so it more closely relates to the unformatted title?

@helfi92
Copy link
Contributor

helfi92 commented Nov 6, 2019

Correct. We should not format the task title and instead use the disableTitleFormatting prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants