Feature: Direct support for full redis URLs

[hardcodet]

As discussed, a follow-up task for the question raised here:

Originally posted by @dan003400 in #53 (comment)

Is there any reason connection does not accept just a redis connection string without the need of importing ioredis?
This seems very odd that you can pass in host / port but not only a string with full connection string...

Thanks for your consideration!

[manast]

After examining this feature more deeply we have realized that the kind of code changes required do not really motivate the change. In order to keep the API clean, we have decided to not support this feature. Instead, it is recommended to just create the redis instance first and pass it as a parameter:

import * as Redis from 'ioredis';

const connection = new Redis('redis:/qweqeqwe');

const queue = new Queue('test', { connection });

[highri5e]

Passing the connection does not work anymore?

"bullmq": "^4.12.0"
"ioredis": "^4.28.3"

Cannot pass the connection to Queue or Worker as shown in the docs.

const conection = new Redis('redis:/qweqeqwe');

const queue = new Queue('test', { connection });

Typescript is complaining about the { connection } object, and building would throw this:

15:39:30 worker.1   |  TypeError: Connection is not a constructor
15:39:30 worker.1   |      at new QueueBase (\node_modules\bullmq\dist\cjs\classes\queue-base.js:41:27)
15:39:30 worker.1   |      at new Worker (\node_modules\bullmq\dist\cjs\classes\worker.js:34:9)

[manast]

@highri5e I wonder if that is the correct code considering you misspelled connection (conection)

[highri5e]

Sorry. The code was copied from your comment, which had the misspell in it.

This is my code:

import IORedis from 'ioredis';

const connection = new IORedis(_config.REDIS_URL);

export class BullMQueue<T> {
  queue: Queue<T>;

  constructor(queueName: string) {
    this.queue = new Queue<T>(queueName, { connection });
  }

  addJob(name: string, data: T, options?: JobsOptions) {
    return this.queue.add(name, data, options);
  }

  addBulk(jobs: { name: string; data: T; options?: JobsOptions }[]) {
    return this.queue.addBulk(jobs);
  }
}

I tried different options. I have to use the url rather than host, port combo because we're using Heroku and that's what's available.

Locally I was not using the redis connection, I was passing connection options with url. While the connection options object was not correct, everything was working because Bull was using the default redis connection.

[manast]

I do not see anything obviously wrong, but here we have some tests that you can use as a starting point to find the issue: https://github.com/taskforcesh/bullmq/blob/master/tests/test_worker.ts#L119