Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for ioredis v5 #1332

Closed
sawa-ko opened this issue Jul 21, 2022 · 3 comments · Fixed by #1364
Closed

Support for ioredis v5 #1332

sawa-ko opened this issue Jul 21, 2022 · 3 comments · Fixed by #1364

Comments

@sawa-ko
Copy link

sawa-ko commented Jul 21, 2022

Are there plans for bullmq to support ioredis v5?
@manast
Copy link
Contributor

manast commented Jul 21, 2022

Yes, but not hurry. What feature of v5 are you missing in v4?

@sawa-ko
Copy link
Author

sawa-ko commented Jul 21, 2022 •
edited

The ability to pass a username in the connection URI, also not rely on @types/ioredis types, compatibility with redis v7 and the various bugs that were fixed.

@boredland boredland mentioned this issue Aug 14, 2022
Merged
@soulchild
Copy link

soulchild commented Aug 22, 2022 •
edited

@manast I just happened to notice that the latest bullmq version still contains @types/ioredis@4 in the devDependencies, but ioredis@5 provides its own types now. I had some problems with that combination in the past and was just wondering whether it'd make sense to just remove @types/redis altogether? Or is there a specific reason why the types are still included?

@roggervalf roggervalf mentioned this issue Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: upgrade to ioredis 5 boredland/bullmq
3 participants
@soulchild @manast @sawa-ko