fix(worker): consider removed jobs in failed event #1500
Conversation
|
I wonder, do we know the underlying reason for the job to be undefined in this particular case? is it possible to fix it so that it always is sent? |
|
it is undefined because it was removed when it was moved to failed as it has removeOnFailed as true |
|
Yes, that makes sense, that it is removed from Redis, but the worker itself should still keep a reference of the job instance, no? |
|
I mean, for the global failed event, yes it must be undefined, but is it really the case for the local worker event? |
|
hey, the escenario where this is happening is when we have stalled jobs that were removed https://github.com/taskforcesh/bullmq/blob/master/src/classes/worker.ts#L790-L797 in that case the only value that is available is the jobId that is returned by stalled script, but as we are creating an instance of a Job with the id of the removed job, we ended with an undefined value |
## [3.2.1](v3.2.0...v3.2.1) (2022-11-15) ### Bug Fixes * **worker:** consider removed jobs in failed event ([#1500](#1500)) ([8704b9a](8704b9a))
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
there is a test case that covers this case https://github.com/taskforcesh/bullmq/blob/master/tests/test_stalled_jobs.ts#L311-L377
ref #1495