Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delay should throw if its not a number #196

Closed
gWOLF3 opened this issue May 5, 2020 · 2 comments
Closed

delay should throw if its not a number #196

gWOLF3 opened this issue May 5, 2020 · 2 comments

Comments

@gWOLF3
Copy link

gWOLF3 commented May 5, 2020

i came across a scenario where delay was failing silently.

it took a while to debug bc i was not seeing any errors.

i saw that the library was being rewritten in TypeScript, maybe consider adding a type check for the delay field. In my case, I was accidentally passing in a string and it seems like the queue schduler did not even know how to handle that.

@manast
Copy link
Contributor

manast commented May 6, 2020

where you using the library from typescript? if so the compiler should take care of it, did't it?

@roggervalf
Copy link
Collaborator

As @manast mentioned, I think would be sufficient to have typescript type checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants