fix(python): add retry strategy in connection #1975

roggervalf · 2023-06-13T03:36:20Z

ref #1940 and https://redis.readthedocs.io/en/latest/retry.html

manast · 2023-06-13T19:25:22Z

python/bullmq/redis_connection.py

        if isinstance(redisOpts, dict):
            host = redisOpts.get("host") or "localhost"
            port = redisOpts.get("port") or 6379
            db = redisOpts.get("db") or 0
            password = redisOpts.get("password") or None

            self.conn = redis.Redis(
-                host=host, port=port, db=db, password=password, decode_responses=True)
+                host=host, port=port, db=db, password=password, decode_responses=True,
+                retry=retry, retry_on_error=[BusyLoadingError, ConnectionError, TimeoutError])


Since the array with the connection errors is used two times I think it could be refactored out.

## [3.15.7](v3.15.6...v3.15.7) (2023-06-16) ### Bug Fixes * **python:** add retry strategy in connection ([#1975](#1975)) ([7c5ee20](7c5ee20)) * **worker:** set redis version always in initialization ([#1989](#1989)) fixes [#1988](#1988) ([a1544a8](a1544a8))

roggervalf added 2 commits June 12, 2023 22:35

fix(python): add retry strategy in connection

5aa919a

chore: fix merge conflicts

38e8657

manast approved these changes Jun 13, 2023

View reviewed changes

refactor(redis-connection): set retry_errors array

0d6e5cb

roggervalf merged commit 7c5ee20 into master Jun 14, 2023
9 of 10 checks passed

roggervalf deleted the redis-python-retry branch June 14, 2023 14:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(python): add retry strategy in connection #1975

fix(python): add retry strategy in connection #1975

roggervalf commented Jun 13, 2023 •

edited

manast Jun 13, 2023

fix(python): add retry strategy in connection #1975

fix(python): add retry strategy in connection #1975

Conversation

roggervalf commented Jun 13, 2023 • edited

manast Jun 13, 2023

Choose a reason for hiding this comment

roggervalf commented Jun 13, 2023 •

edited